swb: annotate BaseDictionary entry items #1819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BaseDictionary Key or Value can be of GC pointer type, potentially needs write barrier on each entry item. Use macro and template type traits to replace underlying entry Key/Value type with WriteBarrierPtr when Key or Value is pointer type and used with recycler allocators. BaseDictionary methods still use original Key/Value types. Only the underlying EntryType may contain swapped type. Most methods are not affected. However, when WriteBarrierPtr is used, only immutable TryGetReference should be used. (We cannot get a mutable reference and possibly change the pointer underneath WriteBarrierPtr.) Allow WriteBarrierPtr to take immutable address to support TryGetReference (used a lot). Fixed a bunch of incorrect `const` usage.
Author
|
@dotnet-bot test Linux tests please |
Author
|
@leirocks @digitalinfinity @curtisman Please help CR, thanks! |
Apply template traits to field types to simplify write barrier field annotations. Now most annotations are Field or FieldNoBarrier (for pointers known not needing write barrier). Replaced `WB_ITEM_TYPE` with `Field`.
leirocks
reviewed
Oct 26, 2016
| return &ptr; | ||
| } | ||
| T** operator&() | ||
| // Taking immutable address is ok |
Contributor
There was a problem hiding this comment.
Taking immutable address is ok [](start = 7, length = 30)
we might need const_cast check in our tool? if so please add a TODO here
Author
There was a problem hiding this comment.
Talked offline. @leirocks's idea is to examine and baseline our usage of const_cast to prevent future incorrect use related to this code. That is doable. Will add a note here.
Contributor
|
|
Author
|
Thanks @leirocks ! |
jianchun
pushed a commit
that referenced
this pull request
Oct 26, 2016
Merge pull request #1819 from jianchun:wbdict BaseDictionary Key or Value can be of GC pointer type, potentially needs write barrier on each entry item. Use macro and template type traits to replace underlying entry Key/Value type with WriteBarrierPtr when Key or Value is pointer type and used with recycler allocators. BaseDictionary methods still use original Key/Value types. Only the underlying EntryType may contain swapped type. Most methods are not affected. However, when WriteBarrierPtr is used, only immutable TryGetReference should be used. (We cannot get a mutable reference and possibly change the pointer underneath WriteBarrierPtr.) Allow WriteBarrierPtr to take immutable address to support TryGetReference (used a lot). Fixed a bunch of incorrect `const` usage. Update: Apply template traits to field types to simplify write barrier field annotations. Now most annotations are Field or FieldNoBarrier (for pointers known not needing write barrier).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BaseDictionary Key or Value can be of GC pointer type, potentially needs
write barrier on each entry item.
Use macro and template type traits to replace underlying entry Key/Value
type with WriteBarrierPtr when Key or Value is pointer type and used with
recycler allocators.
BaseDictionary methods still use original Key/Value types. Only the
underlying EntryType may contain swapped type. Most methods are not
affected. However, when WriteBarrierPtr is used, only immutable
TryGetReference should be used. (We cannot get a mutable reference and
possibly change the pointer underneath WriteBarrierPtr.)
Allow WriteBarrierPtr to take immutable address to support TryGetReference
(used a lot). Fixed a bunch of incorrect
constusage.Update: Apply template traits to field types to simplify write barrier field
annotations. Now most annotations are Field or FieldNoBarrier (for pointers
known not needing write barrier).