asmjs: anonymous function crash #2272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obastemur
force-pushed
the
fix_asmjs_crash
branch
from
c1639ad to
3e445f5
Compare
Collaborator
Author
|
Also added a test case |
Collaborator
Author
|
@dotnet-bot test Ubuntu ubuntu_linux_release |
Contributor
|
|
Cellule
approved these changes
Dec 22, 2016
ThomsonTan
reviewed
Dec 22, 2016
| AsmJsFunc* AsmJsModuleCompiler::CreateNewFunctionEntry( ParseNode* pnodeFnc ) | ||
| { | ||
| PropertyName name = ParserWrapper::FunctionName( pnodeFnc ); | ||
| if ( !name ) |
Collaborator
There was a problem hiding this comment.
name [](start = 14, length = 4)
Do we need use a default name like 'anonymous function' for it?
Contributor
There was a problem hiding this comment.
No, this should be invalid asm.js. Returning null here will invalidate the asm.js module and then be parsed as normal javascript
obastemur
force-pushed
the
fix_asmjs_crash
branch
from
3e445f5 to
5449f72
Compare
Collaborator
Author
|
@Cellule @MikeHolman @ThomsonTan Thanks for the reviews! |
chakrabot
pushed a commit
that referenced
this pull request
Dec 23, 2016
Merge pull request #2272 from obastemur:fix_asmjs_crash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.