Use WCHAR instead of wchar_t #2288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obastemur
force-pushed
the
no_wchar_t
branch
from
d12a094 to
dee1f8c
Compare
ChakraCore uses char16_t on xplat and wchar_t on Windows for 2 bytes wide strings. The reason we alter wchar_t to two bytes char16_t is that Unix wchar_t is 4 bytes long. This PR removes the code that alters wchar_t and replaces all the instances of wchar_t with WCHAR. Only ChakraCommonWindows.h is not updated.
obastemur
force-pushed
the
no_wchar_t
branch
from
dee1f8c to
cb0eaef
Compare
This was referenced Dec 29, 2016
Contributor
|
lgtm; the only small and fairly pedantic comment I have is that theoretically it'd be more predictable using uint16_t to define WCHAR in the two places where it's defined, as that aligns more narrowly with what windows' wchar_t is specified as. In both of the situations where that'd be an issue, though, there'd likely be innumerable other issues from the difference (not to mention windows itself might do things differently there), so doing a char16_t if possible and an unsigned short otherwise should be more than good enough. |
Collaborator
Author
|
@Penguinwizzard Thanks for the review! |
chakrabot
pushed a commit
that referenced
this pull request
Jan 4, 2017
Merge pull request #2288 from obastemur:no_wchar_t ChakraCore uses char16_t on xplat and wchar_t on Windows for 2 bytes wide strings. The reason we alter wchar_t to two bytes char16_t is that Unix wchar_t is 4 bytes long. This PR removes the code that alters wchar_t and replaces all the instances of wchar_t with WCHAR. Only ChakraCommonWindows.h is not updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChakraCore uses char16_t on xplat and wchar_t on Windows for 2 bytes wide strings.
The reason we alter wchar_t to two bytes char16_t is that Unix wchar_t is 4 bytes long.
This PR removes the code that alters wchar_t and replaces all the instances of wchar_t with WCHAR.
Only ChakraCommonWindows.h is not updated.