Don't marshal symbol when it is just created from the same script context #2301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Pointed out by @rajatd. @rajatd @kunalspathak please help review. |
Contributor
|
Looks good to me. |
Contributor
|
LGTM |
chakrabot
pushed a commit
that referenced
this pull request
Dec 31, 2016
…d from the same script context Merge pull request #2301 from ThomsonTan:RemoveUnnecessaryMarshal Marshal symbol in JavascriptObject::CreateKeysHelper is unnecessary because it is just created from the same script context.
chakrabot
pushed a commit
that referenced
this pull request
Dec 31, 2016
…s just created from the same script context Merge pull request #2301 from ThomsonTan:RemoveUnnecessaryMarshal Marshal symbol in JavascriptObject::CreateKeysHelper is unnecessary because it is just created from the same script context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marshal symbol in JavascriptObject::CreateKeysHelper is unnecessary because it is just created from the same script context.