Fix VSO 10259529: Add assertion to satisfy analysis of descriptors[descCount] #2310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…scCount] in JavascriptObject::DefinePropertiesHelperForGenericObjects. JavascriptObject::DefinePropertiesHelperForGenericObjects can reallocate descriptors (doubling the length). The analysis needs to know that the index is still less than the actual size of the array.
dilijev
changed the title
dilijev
changed the title
Collaborator
|
LGTM |
chakrabot
pushed a commit
that referenced
this pull request
Jan 5, 2017
…lysis of descriptors[descCount] Merge pull request #2310 from dilijev:bug10259529 Fix VSO 10259529: Add assertion to satisfy analysis of descriptors[descCount] in JavascriptObject::DefinePropertiesHelperForGenericObjects. Fix some OACR warnings about non-const locals in JavascriptObject.cpp since I was already fixing an OACR warning in the area.
chakrabot
pushed a commit
that referenced
this pull request
Jan 5, 2017
…o satisfy analysis of descriptors[descCount] Merge pull request #2310 from dilijev:bug10259529 Fix VSO 10259529: Add assertion to satisfy analysis of descriptors[descCount] in JavascriptObject::DefinePropertiesHelperForGenericObjects. Fix some OACR warnings about non-const locals in JavascriptObject.cpp since I was already fixing an OACR warning in the area.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix VSO 10259529: Add assertion to satisfy analysis of descriptors[descCount] in JavascriptObject::DefinePropertiesHelperForGenericObjects.
Fix some OACR warnings about non-const locals in JavascriptObject.cpp since I was already fixing an OACR warning in the area.