Adding bounds checking to the TTD string manipulation #2329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GetTTDDirectory() and the dependent functions weren't verifying the bounds of the buffer before writing. This change adds fail fast abort to the string manipulation since it's just a part of the ch test app.
Contributor
|
LGTM |
Contributor
|
You can now resolve the CI issues as described here: #2332 (comment) |
digitalinfinity
approved these changes
Jan 6, 2017
Contributor
|
Jenkins LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The string manipulation wasn't ensuring that the operation would not exceed the bounds of the buffer.
Resolves #2305