Revert the earlier TypedArray change as it may lead to integer overflow. #2350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@Microsoft/chakra-developers |
akroshg
reviewed
Jan 10, 2017
lib/Runtime/Library/TypedArray.cpp
Outdated
| newByteLength = mappedLength * elementSize; | ||
|
|
||
| if (offset + newByteLength > byteLength) | ||
| if ((uint32)mappedLength > (byteLength - offset)/ elementSize) |
Contributor
There was a problem hiding this comment.
In the above ToIndex call you could pass (byteLength - offset)/ elementSize instead of ArrayBuffer::MaxArrayBufferLength / elementSize. That should be same, right?
Contributor
Author
There was a problem hiding this comment.
Yes. I will make that change.
Contributor
|
Looks good, please get Akrosh's signoff as well. |
Contributor
|
|
chakrabot
pushed a commit
that referenced
this pull request
Jan 11, 2017
…ay lead to integer overflow. Merge pull request #2350 from atulkatti:TypedArray.Bug10450472
chakrabot
pushed a commit
that referenced
this pull request
Jan 11, 2017
…hange as it may lead to integer overflow. Merge pull request #2350 from atulkatti:TypedArray.Bug10450472
Collaborator
|
What was the earlier change? Can you please link to the PR number? |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.