xplat: cache thread stack limit #2679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 15, 2017
jianchun
reviewed
Mar 15, 2017
pal/src/thread/pal_thread.cpp
Outdated
| #ifndef __IOS__ | ||
| static THREAD_LOCAL ULONG_PTR s_cachedThreadStackHighLimit = 0; | ||
| static THREAD_LOCAL ULONG_PTR highLimit_cache = 0; | ||
| static THREAD_LOCAL ULONG_PTR lowLimit_cache = 0; |
There was a problem hiding this comment.
nit: highLimit_cache and s_cachedThreadStackHighLimit seems to be the same thing duplicated.
nit: global static variable naming inconsistency.
jianchun
approved these changes
Mar 15, 2017
Collaborator
Author
|
@jianchun Thanks for the review and comments! |
chakrabot
pushed a commit
that referenced
this pull request
Mar 17, 2017
Merge pull request #2679 from obastemur:cache_stackl
chakrabot
pushed a commit
that referenced
this pull request
Mar 17, 2017
Merge pull request #2679 from obastemur:cache_stackl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.