17-04 ChakraCore servicing release #2834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using repeat API on javascript strings, we aren't checking for the upper cap of the length property. Fix: Instead of directly setting the length property in the constructor - We are now calling SetLength() - which also checks for the upper cap and throws OOM. i
When calling eval we pass an additional argument to the function. If we've assigned an asm.js function to eval, then we need to remove that additional argument before getting the arguments
MikeHolman
approved these changes
Apr 13, 2017
rajatd
changed the title
|
LGTM |
chakrabot
pushed a commit
that referenced
this pull request
Apr 14, 2017
Merge pull request #2834 from rajatd:release/1704 Fixes the following CVEs impacting ChakraCore CVE-2017-0093 CVE-2017-0208
chakrabot
pushed a commit
that referenced
this pull request
Apr 14, 2017
Merge pull request #2834 from rajatd:release/1704 Fixes the following CVEs impacting ChakraCore CVE-2017-0093 CVE-2017-0208
chakrabot
pushed a commit
that referenced
this pull request
Apr 14, 2017
…ng release Merge pull request #2834 from rajatd:release/1704 Fixes the following CVEs impacting ChakraCore CVE-2017-0093 CVE-2017-0208
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following CVEs impacting ChakraCore
CVE-2017-0093
CVE-2017-0208