WASM/AsmJs: Fix bad cse between signed/unsigned div&rem #3019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cellule
force-pushed
the
wasm/int_cse
branch
2 times, most recently
from
3ce90b5
to
292ec6a
Compare
…signed/unsigned multiplication
Made a DivChecked and DivUnsafe (and Rem) to make it clear which version does the checks
…ed div/rem. Fixes bad cases of CSE
|
ping |
MikeHolman
approved these changes
Jun 8, 2017
chakrabot
pushed a commit
that referenced
this pull request
Jun 8, 2017
…igned/unsigned div&rem Merge pull request #3019 from Cellule:wasm/int_cse Fixes #2975 - Remove Mul_UInt opcode - Cleanup Div/Rem helper implementation. Made a Checked and an Unsafe version of the implementation. - Created new OpCode DivU_I4 and RemU_I4 to prevent cse between signed and unsigned div/rem
sigatrev
added a commit
to sigatrev/ChakraCore
that referenced
this pull request
Dec 12, 2017
PRs chakra-core#3019, chakra-core#3264, and chakra-core#3509. These occured after the point where the ARM64 starting point was forked.
sigatrev
added a commit
to sigatrev/ChakraCore
that referenced
this pull request
Dec 12, 2017
PRs chakra-core#3019, chakra-core#3264, and chakra-core#3509. These occured after the point where the ARM64 starting point was forked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2975
This change is