Skip to content

Expose platform.winglob to Intl.js to detect which i18n lib we are using in the native code. #3750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chakrabot merged 1 commit into from
Sep 18, 2017
Merged

Expose platform.winglob to Intl.js to detect which i18n lib we are using in the native code. #3750

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/Runtime/Base/JnDirectFields.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -720,6 +720,7 @@ ENTRY(enqueueTask)
ENTRY(Common)
ENTRY(Promise)
ENTRY(MissingProperty)
ENTRY(winglob)

// These are ES5/6/7+ builtins that are tracked for telemetry purposes, but currently not implemented by Chakra or are otherwise special.
// IMPORTANT NOTE: See notes at top of this file regarding GenByteCode and test failures after changing this list.
Expand Down
3,934 changes: 1,967 additions & 1,967 deletions lib/Runtime/Library/InJavascript/Intl.js.bc.32b.h
View file
Open in desktop

Large diffs are not rendered by default.

3,944 changes: 1,972 additions & 1,972 deletions lib/Runtime/Library/InJavascript/Intl.js.bc.64b.h
View file
Open in desktop

Large diffs are not rendered by default.

3,854 changes: 1,927 additions & 1,927 deletions lib/Runtime/Library/InJavascript/Intl.js.nojit.bc.32b.h
View file
Open in desktop

Large diffs are not rendered by default.

3,851 changes: 1,926 additions & 1,925 deletions lib/Runtime/Library/InJavascript/Intl.js.nojit.bc.64b.h
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 6 additions & 0 deletions lib/Runtime/Library/IntlEngineInterfaceExtensionObject.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,6 +311,12 @@ namespace Js
library->AddFunctionToLibraryObject(intlNativeInterfaces, Js::PropertyIds::getHiddenObject, &IntlEngineInterfaceExtensionObject::EntryInfo::Intl_GetHiddenObject, 1);
library->AddFunctionToLibraryObject(intlNativeInterfaces, Js::PropertyIds::setHiddenObject, &IntlEngineInterfaceExtensionObject::EntryInfo::Intl_SetHiddenObject, 1);

#if INTL_WINGLOB
library->AddMember(intlNativeInterfaces, Js::PropertyIds::winglob, library->GetTrue());
#else
library->AddMember(intlNativeInterfaces, Js::PropertyIds::winglob, library->GetFalse());
#endif

intlNativeInterfaces->SetHasNoEnumerableProperties(true);

return true;
Expand Down