Intl-ICU: implement Intl.NumberFormat under ICU#3809

Merged

chakrabot merged 33 commits intochakra-core:intl-icufrom

dilijev:intl-numfmt

Sep 29, 2017

Commits on Sep 29, 2017

Modify build system to only set the ICU include folder in one place

jackhorton
authored and
dilijev
committed
Update bytecode GUID. (Fixes #3773)

jackhorton
authored and
dilijev
committed
CommonDefines.h: define (commented-out) INTL_ICU for convenience while developing.
dilijev
committed
build: Add icui18n.lib to Windows build's link dependencies.
dilijev
committed
tests: added Intl tag to Object/toLocaleStringBasics.js
dilijev
committed
tests: Added require_winglob to tests which fail under Intl-ICU.
dilijev
committed
tests: Fix filename case warnings from runtests.py
dilijev
committed
cleanup: IcuIntlAdapter: be consistent about prefixing error enums with UErrorCode
dilijev
committed
Intl.js: Intl.NumberFormat constructor: change var to let
dilijev
committed
Intl.js: add 'latn' as default value for numberFormat.__numberingSystem
dilijev
committed
Closes #3661: Provide ICU implementation of platform.currencyDigits
dilijev
committed
Closes #3664: Provide ICU implementation of platform.formatNumber
dilijev
committed
platform.cacheNumberFormat; refactor ICU code to PlatformAgnostic.
dilijev
committed
Update CMakeLists.txt for PlatformAgnostic
dilijev
committed
Some xplat fixes.
dilijev
committed
Address review feedback and clean up.
dilijev
committed
Closes #3716: Provide ICU implementation of platform.cacheNumberFormat
dilijev
committed
Ref #3664: Improve ICU implementation of platform.formatNumber
dilijev
committed
Fix build errors on Linux --with-intl
dilijev
committed
Ref #3664: Fix currency formatting in platform.formatNumber
dilijev
committed
.gitignore: lib/wabt/built/
dilijev
committed
review: Use memset instead of zeroing the array in a loop.
dilijev
committed
review: remove gotos; reduce use of auto; check OOM first
dilijev
committed
review: Remove unused code.
dilijev
committed
review: clean up and add notes about casting in Intl.cpp
dilijev
committed
review: make AutoPtr design consistent.
dilijev
committed
review: Add enum classes NumberFormatStyle and NumberFormatCurrencyDisplay and remove magic constants.
dilijev
committed
review: use '#pragma once' in PlatformAgnostic headers.
dilijev
committed
Breaking apart and reclassifying tests.
dilijev
committed
Refactor remainder of IcuIntlAdapter into PlatformAgnostic::Intl
dilijev
committed
Add 'using namespace PlatformAgnostic::Intl' and '...::Resource' to improve readability.
dilijev
committed
Fix whitespace in Intl.js
dilijev
committed
Update bytecode.
dilijev
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Intl-ICU: implement Intl.NumberFormat under ICU#3809

Intl-ICU: implement Intl.NumberFormat under ICU#3809
chakrabot merged 33 commits intochakra-core:intl-icufrom
dilijev:intl-numfmt

Commits on Sep 29, 2017

Modify build system to only set the ICU include folder in one place

Update bytecode GUID. (Fixes #3773)

CommonDefines.h: define (commented-out) INTL_ICU for convenience while developing.

build: Add icui18n.lib to Windows build's link dependencies.

tests: added Intl tag to Object/toLocaleStringBasics.js

tests: Added require_winglob to tests which fail under Intl-ICU.

tests: Fix filename case warnings from runtests.py

cleanup: IcuIntlAdapter: be consistent about prefixing error enums with UErrorCode

Intl.js: Intl.NumberFormat constructor: change var to let

Intl.js: add 'latn' as default value for numberFormat.__numberingSystem

Closes #3661: Provide ICU implementation of platform.currencyDigits

Closes #3664: Provide ICU implementation of platform.formatNumber

platform.cacheNumberFormat; refactor ICU code to PlatformAgnostic.

Update CMakeLists.txt for PlatformAgnostic

Some xplat fixes.

Address review feedback and clean up.

Closes #3716: Provide ICU implementation of platform.cacheNumberFormat

Ref #3664: Improve ICU implementation of platform.formatNumber

Fix build errors on Linux --with-intl

Ref #3664: Fix currency formatting in platform.formatNumber

.gitignore: lib/wabt/built/

review: Use memset instead of zeroing the array in a loop.

review: remove gotos; reduce use of auto; check OOM first

review: Remove unused code.

review: clean up and add notes about casting in Intl.cpp

review: make AutoPtr design consistent.

review: Add enum classes NumberFormatStyle and NumberFormatCurrencyDisplay and remove magic constants.

review: use '#pragma once' in PlatformAgnostic headers.

Breaking apart and reclassifying tests.

Refactor remainder of IcuIntlAdapter into PlatformAgnostic::Intl

Add 'using namespace PlatformAgnostic::Intl' and '...::Resource' to improve readability.

Fix whitespace in Intl.js

Update bytecode.