OS#15334058: Fix class extends null and this access for super property reference
#4629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…perty reference We were supporting some old version of the spec language around classes which extend from null. Instead of leaving `this` undeclared, we were constructing an object and assigning it the `this` binding. This meant we were not throwing ReferenceErrors on access to `this` when we should have been. Also fixed the case where a super property reference failed to access `this` resulting in trying to load a property from null. Fixes: https://microsoft.visualstudio.com/OS/_workitems/edit/15334058
digitalinfinity
approved these changes
Feb 1, 2018
Contributor
digitalinfinity
left a comment
digitalinfinity
left a comment
There was a problem hiding this comment.
Seems reasonable to me
chakrabot
pushed a commit
that referenced
this pull request
Feb 1, 2018
…his` access for super property reference Merge pull request #4629 from boingoing:ClassExtendsNull We were supporting some old version of the spec language around classes which extend from null. Instead of leaving `this` undeclared, we were constructing an object and assigning it the `this` binding. This meant we were not throwing ReferenceErrors on access to `this` when we should have been. Also fixed the case where a super property reference failed to access `this` resulting in trying to load a property from null. Fixes: https://microsoft.visualstudio.com/OS/_workitems/edit/15334058
Contributor
Author
|
Thanks |
chakrabot
pushed a commit
that referenced
this pull request
Feb 1, 2018
…ll` and `this` access for super property reference Merge pull request #4629 from boingoing:ClassExtendsNull We were supporting some old version of the spec language around classes which extend from null. Instead of leaving `this` undeclared, we were constructing an object and assigning it the `this` binding. This meant we were not throwing ReferenceErrors on access to `this` when we should have been. Also fixed the case where a super property reference failed to access `this` resulting in trying to load a property from null. Fixes: https://microsoft.visualstudio.com/OS/_workitems/edit/15334058
chakrabot
pushed a commit
that referenced
this pull request
Feb 1, 2018
…ss extends null` and `this` access for super property reference Merge pull request #4629 from boingoing:ClassExtendsNull We were supporting some old version of the spec language around classes which extend from null. Instead of leaving `this` undeclared, we were constructing an object and assigning it the `this` binding. This meant we were not throwing ReferenceErrors on access to `this` when we should have been. Also fixed the case where a super property reference failed to access `this` resulting in trying to load a property from null. Fixes: https://microsoft.visualstudio.com/OS/_workitems/edit/15334058
|
@oliverchang This was found by OSS-Fuzz, issue 4831. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were supporting some old version of the spec language around classes which extend from null. Instead of leaving
thisundeclared, we were constructing an object and assigning it thethisbinding. This meant we were not throwing ReferenceErrors on access tothiswhen we should have been.Also fixed the case where a super property reference failed to access
thisresulting in trying to load a property from null.Fixes:
https://microsoft.visualstudio.com/OS/_workitems/edit/15334058