Modernize CI configuration: Modern = RS4 + Dev 15.7; Legacy = (2008 R2 & 2012 R2) + Dev14 #5307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Replaces #5280 |
This was referenced Jun 13, 2018
MSLaguana
approved these changes
Jun 13, 2018
Contributor
Author
|
@dotnet-bot test ci please |
2 similar comments
Contributor
Author
|
@dotnet-bot test ci please |
Contributor
Author
|
@dotnet-bot test ci please |
dilijev
changed the title
… + Dev14 * Update Windows build matrix to use a modernized CI configuration: Modern = RS4 + Dev 15.7 and Legacy = Server 2008 R2 + Dev14 * Update script logic for forcing detection of a specific msbuild version Note that the legacy config is the same as before (2008 R2 ~= Windows 7 SP1) which is the lowest Windows OS version ChakraCore supports, and VS 2015 / Dev14 is the lowest Visual Studio version ChakraCore supports. Unfortunately this configuration leaves out coverage for any Windows 8 versions (Modern config was previously 2012 R2 ~= Windows 8.1).
dilijev
changed the title
dilijev
force-pushed
the
ci-updated-legacy-110
branch
from
fa7ca17 to
98cbeff
Compare
Contributor
Author
|
@dotnet-bot test ci please |
Contributor
Author
|
@MSLaguana @jackhorton @digitalinfinity @Penguinwizzard I have added the Win 8.1 Blue daily builds. @dotnet-bot test ci please |
… fix Modern test param to be -win10
dilijev
force-pushed
the
ci-updated-legacy-110
branch
from
4d99cdc to
7ea3fce
Compare
Contributor
Author
|
@dotnet-bot test ci please |
dilijev
changed the title
Contributor
Author
|
@dotnet-bot test ci please |
Contributor
Author
|
@dotnet-bot |
Contributor
Author
|
@dotnet-bot test ci please |
Contributor
Author
|
@MSLaguana @Penguinwizzard @boingoing would you mind reviewing the latest revision? |
chakrabot
pushed a commit
that referenced
this pull request
Jun 29, 2018
… 15.7; Legacy = (2008 R2 & 2012 R2) + Dev14 Merge pull request #5307 from dilijev:ci-updated-legacy-110 * Update Windows build matrix to use a modernized CI configuration: Modern = RS4 + Dev 15.7 and Legacy7 = Server 2008 R2 + Dev14 and Legacy8 = Server 2012 R2 + Dev14 * Update script logic for forcing detection of a specific msbuild version Note that the legacy OS is the same as before (2008 R2 ~= Windows 7 SP1) which is the lowest Windows OS version ChakraCore supports, and the legacy version of VS has been updated to VS 2015 / Dev14, which is now the lowest Visual Studio version ChakraCore supports (since Dev12 support was dropped). This change also adds a second legacy configuration for 2012 R2 ~= Windows 8.1 Blue.
chakrabot
pushed a commit
that referenced
this pull request
Jun 29, 2018
…rn = RS4 + Dev 15.7; Legacy = (2008 R2 & 2012 R2) + Dev14 Merge pull request #5307 from dilijev:ci-updated-legacy-110 * Update Windows build matrix to use a modernized CI configuration: Modern = RS4 + Dev 15.7 and Legacy7 = Server 2008 R2 + Dev14 and Legacy8 = Server 2012 R2 + Dev14 * Update script logic for forcing detection of a specific msbuild version Note that the legacy OS is the same as before (2008 R2 ~= Windows 7 SP1) which is the lowest Windows OS version ChakraCore supports, and the legacy version of VS has been updated to VS 2015 / Dev14, which is now the lowest Visual Studio version ChakraCore supports (since Dev12 support was dropped). This change also adds a second legacy configuration for 2012 R2 ~= Windows 8.1 Blue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that the legacy OS is the same as before (2008 R2 ~= Windows 7 SP1) which is the lowest Windows OS version ChakraCore supports, and the legacy version of VS has been updated to VS 2015 / Dev14, which is now the lowest Visual Studio version ChakraCore supports (since Dev12 support was dropped).
This change also adds a second legacy configuration for 2012 R2 ~= Windows 8.1 Blue.