OS#17895855 - Concise-body lambda function followed by in keyword is not handled correctly #5380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not handled correctly At the moment we parse this as a postfix operator, it should be part of the lambda body except for when we're parsing a for..in loop header. Fixes: https://microsoft.visualstudio.com/OS/_workitems/edit/17895855
jackhorton
approved these changes
Jun 28, 2018
MSLaguana
approved these changes
Jun 28, 2018
|
LGTM |
chakrabot
pushed a commit
that referenced
this pull request
Jun 28, 2018
…ollowed by in keyword is not handled correctly Merge pull request #5380 from boingoing:lambda_concise_body_in_expression At the moment we parse this as a postfix operator, it should be part of the lambda body except for when we're parsing a for..in loop header. Fixes: https://microsoft.visualstudio.com/OS/_workitems/edit/17895855
|
Thanks, all |
chakrabot
pushed a commit
that referenced
this pull request
Jun 28, 2018
…bda function followed by in keyword is not handled correctly Merge pull request #5380 from boingoing:lambda_concise_body_in_expression At the moment we parse this as a postfix operator, it should be part of the lambda body except for when we're parsing a for..in loop header. Fixes: https://microsoft.visualstudio.com/OS/_workitems/edit/17895855
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment we parse this as a postfix operator, it should be part of the lambda body except for when we're parsing a for..in loop header.
Fixes:
https://microsoft.visualstudio.com/OS/_workitems/edit/17895855