Enable es6 prototype chain by default #5407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSLaguana
commented
Jul 2, 2018
test/Date/DateGetSet.js
Outdated
| @@ -182,15 +182,3 @@ WScript.Echo("valueOf : " + d.valueOf()) | |||
|
|
|||
| WScript.Echo("toISOString method : " + typeof d.toISOString); | |||
| WScript.Echo("toJSON method : " + typeof d.toJSON); | |||
|
|
|||
| // Set fullYear/fullYear+month/year on the Date prototype | |||
| Date.prototype.setYear(5); // Year | |||
There was a problem hiding this comment.
This is explicitly not supported in es6; Date.prototype is no longer a Date so you can't set its year.
There was a problem hiding this comment.
nit: Rather than removing all of the cases, could you make them assert_fails instead?
MSLaguana
force-pushed
the
enableEs6PrototypeChain
branch
from
405973a to
dab3f5c
Compare
|
@dotnet-bot test Windows 10 ci_slow_x64_debug please |
sethbrenith
approved these changes
Jul 2, 2018
akroshg
reviewed
Jul 3, 2018
lib/Common/ConfigFlagsList.h
Outdated
| @@ -626,12 +626,16 @@ PHASE(All) | |||
| #define DEFAULT_CONFIG_ES6String (true) | |||
| #define DEFAULT_CONFIG_ES6StringPrototypeFixes (true) | |||
| #define DEFAULT_CONFIG_ES2018ObjectSpread (false) | |||
|
|
|||
| #ifndef DEFAULT_CONFIG_ES6PrototypeChain | |||
| #ifdef COMPILE_DISABLE_ES6PrototypeChain | |||
There was a problem hiding this comment.
I think we can get rid of this COMPILE_DISABLE* for this one as this is enabled now.
dilijev
approved these changes
Jul 4, 2018
MSLaguana
force-pushed
the
enableEs6PrototypeChain
branch
2 times, most recently
from
4722ef6 to
289cdfe
Compare
kfarnung
approved these changes
Jul 5, 2018
MSLaguana
force-pushed
the
enableEs6PrototypeChain
branch
from
289cdfe to
82fad63
Compare
chakrabot
pushed a commit
that referenced
this pull request
Sep 11, 2018
We want to enable the `-Es6PrototypeChain` flag by default to support the spec better. Most of this PR is updating test baselines. Fixes #5065
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to enable the
-Es6PrototypeChainflag by default to support the spec better. Most of this PR is updating test baselines.Fixes #5065