OS 18333466 : Recursion in the generator next call. #5519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aneeshdk please have a look |
| { | ||
| JavascriptExceptionOperators::DoThrow(exceptionObj, scriptContext); | ||
| JavascriptExceptionOperators::DoThrowCheckClone(exception, scriptContext); |
There was a problem hiding this comment.
DoThrowCheckClone [](start = 50, length = 17)
Why does it need to change from DoThrow to DoThrowCheckClone?
|
A similar pattern (a catch with a DoThrow in it) looks like it is in |
|
@irinayat-MS for OOM and SO we used to clone them as they are static exception. It seems I saw that pattern that's why I changed to that. |
|
@MSLaguana thanks for finding that out. I'll make that change |
|
@irinayat-MS yes - it seems like that is right. |
|
LGTM |
Moving exception throw out from the catch handler. Otherwise we will throw hard stack overflow. Fixed that in the DoIteratorStepAndValue as well
MSLaguana
approved these changes
Jul 25, 2018
chakrabot
pushed a commit
that referenced
this pull request
Jul 25, 2018
chakrabot
pushed a commit
that referenced
this pull request
Jul 25, 2018
…enerator next call. Merge pull request #5519 from akroshg:generator Moving exception throw out from the catch handler. Otherwise we will throw hard stack overflow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving exception throw out from the catch handler. Otherwise we will throw hard stack overflow.