Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude this test for jshost #5628

Merged

Conversation

duongnhn
Copy link
Contributor

@duongnhn duongnhn commented Aug 24, 2018

related to this PR: #5623

@duongnhn duongnhn requested a review from kfarnung August 24, 2018 00:33
@duongnhn duongnhn force-pushed the user/duongn/clear-exception-wscript branch from 2540583 to 580a6ae Compare August 24, 2018 00:43
Copy link
Contributor

@boingoing boingoing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, but are there plans to get this working on jshost?

@duongnhn
Copy link
Contributor Author

@taylor.woll@microsoft.com : currently we don't have this issue with jshost. It goes with different code path and end up throw different error.

@chakrabot chakrabot merged commit 580a6ae into chakra-core:master Aug 24, 2018
chakrabot pushed a commit that referenced this pull request Aug 24, 2018
Merge pull request #5628 from duongnhn:user/duongn/clear-exception-wscript

related to this PR: #5623
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants