enable IsIn optimization for addrOpnds #5671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Wouldn't a better way to handle this be to have |
Contributor
Author
|
@rajatd The original opnd for the numeric literal is an IntConstOpnd, the AddrOpnd is created by GlobOpt::CopyProp, turning this: into this: |
numeric literal copy proped to var opnds are handled as addrOpnds. This change allows handling of addr opnds for the IsIn optimization, allowing us to optimize ```if (0 in array) ...```.
Contributor
|
I see. I would then try to understand why the CopyProp creates an AddrOpnd. Still don't see why can't we just use an |
Contributor
|
Oh I see, AddrOpnd is required to represent a tagged int. |
chakrabot
pushed a commit
that referenced
this pull request
Sep 8, 2018
Merge pull request #5671 from sigatrev:isInAddr numeric literal copy proped to var opnds are handled as addrOpnds. This change allows handling of addr opnds for the IsIn optimization, allowing us to optimize ```if (0 in array) ...```.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
numeric literal copy proped to var opnds are handled as addrOpnds. This change allows handling of addr opnds for the IsIn optimization, allowing us to optimize
if (0 in array) ....