Fixes #5477 - Forces computed property names within classes to be executed in strict mode #5689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethbrenith
reviewed
Sep 11, 2018
jackhorton
reviewed
Sep 11, 2018
wyrichte
changed the title
sethbrenith
reviewed
Sep 11, 2018
|
|
||
| // Strict mode must be enforced on the evaluation of computed property names inside | ||
| // classes, thus enable the flag if the computed property name is a class member. | ||
| byteCodeGenerator->forceStrictModeForClassComputedPropertyName = isClassMember; |
There was a problem hiding this comment.
I feel like maybe here we should be setting isClassMember || prevFlag. Consider the following (which might be a nice test case too): class C { [{[a.b=3]: 4}[3]]() {} }. Inside the computed method name on the class (strict mode), we have a computed property name for an object literal (which I believe should also be strict mode, because strict mode affects anything lexically inside the expression).
akroshg
reviewed
Sep 11, 2018
wyrichte
force-pushed
the
bug_5477_fixed
branch
from
8cf7bd8 to
2e1392b
Compare
dilijev
reviewed
Sep 12, 2018
wyrichte
force-pushed
the
bug_5477_fixed
branch
from
125b2ab to
84292eb
Compare
…s to be executed in strict mode The ECMA spec requires that a class definition is always strict mode code, this includes computed property names within classes. A flag, forceStrictModeForClassComputedPropertyName, is added into ByteCodeGenerator.h. When set, this flag will force bytecode opcodes to be emitted in strict mode when avaliable. This flag is set outside of emit calls under the condition that the bytecode being emitted corresponds to computed property names within classes.
wyrichte
force-pushed
the
bug_5477_fixed
branch
from
4c099d6 to
4f3f3bf
Compare
pleath
pushed a commit
to pleath/ChakraCore
that referenced
this pull request
Sep 14, 2018
…mputed property names within classes to be executed in strict mode Merge pull request chakra-core#5689 from wyrichte:bug_5477_fixed Forces computed property names within classes to be executed in strict mode. The ECMA spec requires that a class definition is always strict mode code, this includes computed property names within classes. A flag, forceStrictModeForClassComputedPropertyName, is added into ByteCodeGenerator.h. When set, this flag will force bytecode opcodes to be emitted in strict mode when avaliable. This flag is set outside of emit calls under the condition that the bytecode being emitted corresponds to computed property names within classes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forces computed property names within classes to be executed in strict mode.
The ECMA spec requires that a class definition is always strict mode code, this includes computed property names within classes. A flag, forceStrictModeForClassComputedPropertyName, is added into ByteCodeGenerator.h. When set, this flag will force bytecode opcodes to be emitted in strict mode when avaliable. This flag is set outside of emit calls under the condition that the bytecode being emitted corresponds to computed property names within classes.