Fixes #5201: Implemented StringTemplate Caching based on location in source Code. #5727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the earlier implementation of caching the StringTemplates based on Raw String Literals to their location in the source code.
sharmasuraj0123
changed the title
|
Make sure you put |
sharmasuraj0123
changed the title
chakrabot
pushed a commit
that referenced
this pull request
Sep 26, 2018
…e Caching based on location in source Code. Merge pull request #5727 from sharmasuraj0123:StringTemplateCaching Changed the earlier implementation of caching the StringTemplates based on Raw String Literals to their location in the source code. Old Behavior: ```js function getCallsite(c) { return c; } function getFooCallsite() { return getCallsite`foo`; } print(getFooCallsite() === getFooCallsite()); // true print(getCallsite`foo` === getCallsite`foo`); // true print(getCallsite`foo` === eval('getCallsite`foo`')); // true ``` New Behavior: ```js function getCallsite(c) { return c; } function getFooCallsite() { return getCallsite`foo`; } print(getFooCallsite() === getFooCallsite()); // true print(getCallsite`foo` === getCallsite`foo`); // false print(getCallsite`foo` === eval('getCallsite`foo`')); // false ``` Deleted the added mapping that would compare and ensure that the two callsite objects are equal based on their raw String literals. Now it store every diferent pnode object it comes accross and assigns it a register. Fixes #5201
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the earlier implementation of caching the StringTemplates based
on Raw String Literals to their location in the source code.
Old Behavior:
New Behavior:
Deleted the added mapping that would compare and ensure that the two callsite objects are equal based on their raw String literals.
Now it store every diferent pnode object it comes accross and assigns it a register.
Fixes #5201