disable switch opt when breaking out of loops #6000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pleath
approved these changes
Mar 8, 2019
MikeHolman
force-pushed
the
switchoptloop
branch
from
14a8af9 to
38c240d
Compare
MikeHolman
added a commit
to MikeHolman/ChakraCore
that referenced
this pull request
Mar 11, 2019
… out of loops Merge pull request chakra-core#6000 from MikeHolman:switchoptloop Switch opt gets confused when we need to branch to labels outside the loop, so just disabling it in this case. Fixes chakra-core#5985
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch opt gets confused when we need to branch to labels outside the loop, so just disabling it in this case.
Fixes #5985