Rework how captured values are written to GeneratorBailInInstrs #6293
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an existing bug in the generator JIT implementation found by @rhuanjl.
In order to generate bail-in code, the backward pass copies "captured value" information from a yield's
BailOutInfo
into the associatedGeneratorBailInInstr
. The current implementation was copyingbailOutInfo->capturedValues->constantValues
on every pass over the yield instr. However, in a loop the yield instr is passed over twice, and each time entries are moved frombailOutInfo->capturedValues
intobailOutInfo->usedCapturedValues
. On the second pass over the instr, the current implementation is overwriting the constant values list with an empty list.With this change, the constant values are transferred to the bailin instr directly in the code that processes bailout constant values and copy prop syms.