Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix project building on Ubuntu 19.10 #6418

Merged
merged 1 commit into from
Apr 15, 2020

Conversation

Fly-Style
Copy link
Contributor

I upgrade my Ubuntu version to 19.10 and realize that CC isn't building on this OS version.
It happened because sysctl is deprecated. I fixed that by preferring sysconf.

A similar issue happens in Dotnet.

@ppenzin ppenzin requested a review from rhuanjl April 14, 2020 07:25
@Fly-Style Fly-Style force-pushed the ubuntu19-10-build-fix branch from ce6bc8f to 9396169 Compare April 14, 2020 08:58
@Fly-Style Fly-Style force-pushed the ubuntu19-10-build-fix branch from 9396169 to 392d5c3 Compare April 14, 2020 12:39
@ppenzin
Copy link
Member

ppenzin commented Apr 15, 2020

@divmain @boingoing do you know how to get the CI to unstuck?

@Fly-Style Fly-Style force-pushed the ubuntu19-10-build-fix branch from 392d5c3 to a27940d Compare April 15, 2020 15:51
@boingoing
Copy link
Contributor

@ppenzin I restarted the failed MacOS job. If you click through the Details link there's a button to rerun failed tasks. I believe that UI is public.

@ppenzin ppenzin merged commit 63e5d6b into chakra-core:master Apr 15, 2020
@Fly-Style Fly-Style deleted the ubuntu19-10-build-fix branch April 15, 2020 18:29
@ppenzin
Copy link
Member

ppenzin commented Apr 16, 2020

@boingoing I can't seem to find it, what page should it be on? I created a Microsoft account and logged in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants