-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add style checks #6571
Add style checks #6571
Conversation
2bb0c8d
to
570d795
Compare
@@ -18,7 +19,7 @@ rm -f $ERRFILE | |||
rm -f $ERRFILETEMP | |||
|
|||
echo "Check Copyright > Begin Checking..." | |||
git diff --name-only `git merge-base origin/$ghprbTargetBranch HEAD` HEAD | | |||
git diff --name-only `git merge-base origin/master HEAD` HEAD | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This instruction didn't work - edited to fix (by bringing in line with the logic in the other check scripts
Test failure is a timeout on a wasm test - I did a re-run and it timed out again though on a different test - maybe just a slow time of night or something? (the runtests script counts any test taking more than 1 minut as a timeout and fails it) |
Clang format for the whole repository could well be quite a significant change - the historic style checks that this includes are quite minimal and aimed at avoiding specific problems:
A more extensive consistent style across the whole code base could be very nice for welcoming new contributors but how much work would it be? And how beneficially would it be? (That said if you'd like to try it and open a PR I'll take a look) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from feeling ambivalent about MSFT copyright in new files, this looks good.
@@ -59,7 +60,7 @@ if [ -e $ERRFILE ]; then # if error file exists then there were errors | |||
>&2 echo "--- ERRORS ---" | |||
cat $ERRFILE 1>&2 # send output to stderr so it can be redirected as error if desired | |||
>&2 echo "--------------" | |||
exit 1 # tell the caller there was an error (so Jenkins will fail the CI task) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to keep make it more future-proof, you can remove the name of the CI system we are using. I don't think it is critical, we can keep Azure here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you might still need exit 1
, otherwise Azure may not pick the failure up.
@ppenzin I've done the updates and exclude .yml from the copyright check so we don't have to say copyright microsoft in the CI script. |
I considered renaming the
jenkins
folder as it's nothing to do with jenkins - but there were a lot of things to change based on that and it seemed like too big a diff to be worth it.For reference these "Style" checks do:
For #6547
Fixes: #6548