Fix incorrect failFast for Incr0 #6785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@ppenzin this one was very easy (sorry I've been mostly inactive for a while - will see if I can try and do a bit each week but life has got busier...) |
Member
|
I got really busy too. I think I will have more time in the next months and a half, hopefully we can get some things done :) |
ppenzin
approved these changes
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a simple incorrect FailFast the existing logic accounted for
v = v + xorv = v - xfor any integerxexcept for 0 - adjusted to allow for 0.The existing logic falsely saw the optimised code produced from
v = v + 0in the increment section of a loop control as invalid code hence aborted.Fixes #6763