Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JsDisableRuntimeExecution on AppleSilicon #6995

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

rhuanjl
Copy link
Collaborator

@rhuanjl rhuanjl commented Jun 14, 2024

JsDisableRuntimeExecution currently does not function on AppleSilicon.

This is because of an incorrect ifdef, JsDisableRuntimeExecution works by overriding CC's stack size tracking so that CC mistakenly thinks there is no stack space left and hence stops executing JS; in order to do this StackLimitForScriptInterrupt needs to be an appropriately large number for the architecture, currently it's being set to the same size on AppleSilicon that was used for x86 which is obviously not high enough, change the ifdef so all 64bit architectures (i.e. x64 and AppleSilicon) get the larger figure.

Bug reported by @fatcerberus fix also tested offline by @fatcerberus

Currently most of our native API tests only run on windows hence do not detect this; we should look at enabling them on macOS/Linux as a future todo.

@ppenzin
Copy link
Member

ppenzin commented Jul 3, 2024

I need to check my email a bit more often, sorry. It is failing in debug mode on Windows, but Azure already helpfully deleted the build, I am trying to re-run it.

@ppenzin
Copy link
Member

ppenzin commented Jul 6, 2024

My suspicion is that CI failures are stringize issue returning. I went ahead and merged the relevant PR, this would probably clear after rebase.

Copy link
Member

@ppenzin ppenzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be fine as long as CI is happy.

@rhuanjl rhuanjl merged commit e26c81f into chakra-core:master Aug 1, 2024
24 checks passed
@rhuanjl rhuanjl deleted the fixArm64DisableRuntime branch August 1, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants