-
Notifications
You must be signed in to change notification settings - Fork 1.2k
ci: use windows 2025 runners #7048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
ci: use windows 2025 runners #7048
Conversation
acc22ee to
22393f5
Compare
|
So, the Windows globalisation implementation doesn't work on latest windows AND the ICU alternative fails too, weirdly the test runner seems to be crashing out after one of the fails rather than finishing and saying how many tests failed.... that is awkward. A couple of test fails look like things that are may be fairly easily fixable e.g. ICU version mismatches to amend tests for or inconsistent conditions in the test suite that expect windows to not be ICU etc. Hopefully it's not overall too big a job but I have no setup I can work on this on. |
|
I'll look into this in the next view weeks |
22393f5 to
659a32f
Compare
|
The windows-2019 test runners are now disabled.... So all CI runs now fail. |
`windows-2019` → `windows-2022`
efab8ed to
4135302
Compare
| <BuildChakraICUData Condition="'$(BuildChakraICUData)'=='' AND ('$(ChakraICU)'=='static' OR '$(ChakraICU)'=='shared')">true</BuildChakraICUData> | ||
|
|
||
| <IcuLibraryDependencies Condition="'$(ChakraICU)'=='windows'">icuuc.lib;icuin.lib</IcuLibraryDependencies> | ||
| <IcuLibraryDependencies Condition="'$(ChakraICU)'=='windows'">icu.lib</IcuLibraryDependencies> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "constructor": "function <large string>", | ||
| "resolvedOptions": "function <large string>", | ||
| "compare": "function <large string>" | ||
| "compare": "Error <large string>" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why these results changed...
4135302 to
18eaa7e
Compare
a240230 to
a931ead
Compare
|
@ppenzin What do you think? This fixes INTL on windows newer than the May 2019 Update but breaks it on older versions - though the key change is just build config we could perhaps document how to build the older version? |
windows-2019actions are unsupported as of 30.06.2025.This PR updates the ci-config to run on the supported versions of the windows runner:
windows-2022→windows-2025windows-2019→windows-2022💥 Breaking changes
This config is broken on recent versions of Windows 11 as CC does not initialize WinRT using RoInitialize to allow for some optimizations.
This removes compat of the default config with all windows versions < Version 1903 (May 2019 Update)
Should be fine as Windows 10 is out-of-support anyway...
🧪 Tests
win32 => WinGlob; that is obviously wrong now.The "new" behavior is consistent with recent node.js and bun.js
See actions/runner-images#12045
Fixes #7045
Fixes #4490