refactor: popper package #3583
Merged
refactor: popper package #3583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/chakra-ui/chakra-ui/3zgmZFBQN1gAJhsNAmGjhrBpRWF9 |
🦋 Changeset detectedLatest commit: 47e3d79 The changes in this PR will be included in the next version bump. This PR includes changesets to release 57 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
segunadebayo
added
Popper.js 🍿
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 47e3d79:
|
This was referenced Mar 15, 2021
added 4 commits
March 16, 2021 14:21
Remove generic string type in system and styled-system which conflicts with the generated textStyles type
… config This config is only consumed by extractPropertyPath, which we don't use for layerStyles or textStyles theme generation
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3433 #2481 #3385 #3089 #3384 #3440
📝 Description
This PR refactors the internal popper package to:
usePopperand let popper.js write the styles internal. I found this is more reliable and works consistently.liteversion of popper.js to get a smaller bundle sizepopperGeneratorwhich gives us an agnostic base for all popper implementations across React and Vue.⛳️ Current behavior (updates)
There seem to be a lot of inconsistencies or issues with the placement of components and there were some hacks we had but didn't work well.
🚀 New behavior
Allows popper.js to handle all style computation and remove internal state. This is consistent and more reliable
💣 Is this a breaking change (Yes/No):
No, as
usePopperis an internal API📝 Additional Information