perf: improve runtime performance #1986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1db635f The changes in this PR will be included in the next version bump. This PR includes changesets to release 21 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Great work! Did some performance comparisons, rendering 100 instances of a component using cva. Before After Diff |
Those improvements in percentage look a bit off. Imho it should be 66.97% faster for mounting and 46.67% for updating ?! |
astahmer
force-pushed
the
perf/runtime-cva
branch
from
feffb13 to
9c9555f
Compare
astahmer
force-pushed
the
perf/runtime-cva
branch
from
0dedf1a to
1db635f
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1982
📝 Description
Improve the performance of the runtime transform functions by caching their results (css, cva, sva, recipe/slot recipe,
patterns)
since Panda has to transform style objects to classes (
{ backgroundColor: "red.300" }->bg_red, it will always have a little bit of overhead vs just writing the final classes, caching those reduce the time spent on it.💣 Is this a breaking change (Yes/No):
no
📝 Additional Information
if you're using anything that can pre-render to HTML (Astro, RSC, etc) you can avoid this issue entirely by automatically inlining classes at build-time, without ever needing those runtime functions