Skip to content

Commit

Permalink
Remove some logging in 0.7.1, simplify some code
Browse files Browse the repository at this point in the history
  • Loading branch information
rewrking committed Feb 11, 2024
1 parent b5d096f commit 77b859e
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 20 deletions.
4 changes: 4 additions & 0 deletions Extension/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Change Log

## Version 0.7.2

- Remove some logging in 0.7.1, simplify some code

## Version 0.7.1

- When ending the Chalet process via the trash icon on unix platforms, use `tree-kill` to make sure child processes close as well
Expand Down
2 changes: 1 addition & 1 deletion Extension/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "vscode-chalet",
"displayName": "Chalet",
"description": "Support for Chalet projects in Visual Studio Code",
"version": "0.7.1",
"version": "0.7.2",
"publisher": "chalet-org",
"license": "BSD-3-Clause",
"icon": "chalet-logo.png",
Expand Down
25 changes: 6 additions & 19 deletions Extension/src/Terminal/TerminalProcess.ts
Original file line number Diff line number Diff line change
Expand Up @@ -74,26 +74,13 @@ class TerminalProcess {
const pid = this.subprocess.pid;

const callback = (err: any) => {
// Note: We don't care about the error
// if (!!err) OutputChannel.logError(err);

if (this.platform === VSCodePlatform.Windows) {
if (!!err) {
console.error(err);
console.error("there was an error halting the process");
} else {
this.subprocess = null;
onHalt?.();
}
if (!!err) {
// OutputChannel.logError(err);
console.error(err);
console.error("there was an error halting the process");
} else {
if (!!err) {
console.error(err);
console.error("there was an error halting the process");
} else {
console.log("task killed successfully");
this.subprocess = null;
onHalt?.();
}
this.subprocess = null;
onHalt?.();
}
};

Expand Down

0 comments on commit 77b859e

Please sign in to comment.