Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove now moot VSCode check #80

Merged
merged 1 commit into from
Apr 17, 2018

Conversation

rbergman
Copy link
Contributor

@rbergman rbergman commented Apr 11, 2018

VSCode appears to now set stream.isTTY in the debugger.

Fixes #79

@rbergman
Copy link
Contributor Author

image

@wuweiweiwu
Copy link
Contributor

LGTM 👍 Seems the debugger has been updated

@sindresorhus sindresorhus changed the title VSCode appears to now set stream.isTTY in the debugger Remove now moot VSCode check Apr 17, 2018
@sindresorhus sindresorhus merged commit 65088b2 into chalk:master Apr 17, 2018
@jecot
Copy link

jecot commented May 1, 2020

I am running windows 10, VSCode 1.44.2, chalk 4.0.0 and it seems my debug console still outputs undefined for process.stdout.isTTY while the terminal outputs true.
So again, I have the that same issue #254 and the same fix #77 still does the job for me.
Should I fork?
Am I missing anything?
(sorry if this comment is out of place...)

@ev5unleash
Copy link

Having a similar problem with NodeJS + Chalk. All test is now white.

@MarByteBeep
Copy link

This still seems to be an issue. Latest version of VS Code (1.51.1) and Chalk (4.1.0). When running in VS, the output is white for 'log' and 'info', and red for 'warn' and 'error'. There is no possible way to control these colors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VSCODE_PID check breaks color suppression in stream redirection in VSCode's integrated terminal
6 participants