Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting Error after vuex and vuex-module-decorators upgraded #90

Closed
kisonay opened this issue Feb 2, 2019 · 8 comments
Closed

Linting Error after vuex and vuex-module-decorators upgraded #90

kisonay opened this issue Feb 2, 2019 · 8 comments

Comments

@kisonay
Copy link

kisonay commented Feb 2, 2019

After upgrading vuex to 3.1.0 I am receiving the following linting error even though node_modules is excluded and no other node module reports any warnings or error:

ERROR in .../node_modules/vuex-module-decorators/dist/types/vuexmodule.d.ts
2:46 Type parameter defaults can only reference previously declared type parameters.
    1 | import { ActionTree, GetterTree, Module as Mod, ModuleTree, MutationTree, Store, ActionContext } from 'vuex';
  > 2 | export declare class VuexModule<S = ThisType<S>, R = any> implements Mod<S, R> {
      |                                              ^
    3 |     static namespaced?: boolean;
    4 |     static state?: any | (() => any);
    5 |     static getters?: GetterTree<any, any>;

Any ideas why this would happend out of nowhere?

::EDIT::
Looks unrelated to the upgrade. Downgrading doesn’t remove the error. Looks to be related to my usage of it. I’ll continue to debug. Just strange since it is an exclude directory.

@mantas6
Copy link

mantas6 commented Feb 4, 2019

I've started to get this error after upgrading typescript from 3.2.4 to 3.3.1. Currently reading the changelog, it doesn't seem to indicate any changes in generics. Possibly it was one of the bugfixes.

@championswimmer
Copy link
Owner

championswimmer commented Feb 4, 2019 via email

@kisonay
Copy link
Author

kisonay commented Feb 4, 2019

@MantasPauliukonis @championswimmer thank you both. I knew it had something to do with an upgrade, didn't even dawn on me to check if typescript was updated.

@newink
Copy link

newink commented Feb 4, 2019

Did not update anything, typescript 3.0.0 this error just appeared from nowhere, did you manage to solve it?

@kisonay
Copy link
Author

kisonay commented Feb 4, 2019

@newink. Not yet on my end.

@holwech
Copy link

holwech commented Feb 4, 2019

The error is related to the Typescript package, downgrade to 3.2.4 and the error disappears. For anyone who needs a temporary fix, run npm install typescript@3.2.4.

@Saravanan-Duraisamy
Copy link

Facing the same issue. Followed @holwech advice.
Downgraded Typescript from 3.3.1 to 3.2.4 and that solved the problem for now.

@championswimmer
Copy link
Owner

v0.9.8 is compatible with latest Tyescript :) please upgrade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants