Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on leading zeros when decoding indices #66

Merged
merged 4 commits into from
Aug 6, 2024
Merged

Conversation

asmello
Copy link
Collaborator

@asmello asmello commented Aug 5, 2024

In the process of migrating json-patch to version 0.5.1, I noticed one of their test cases was failing because we accept leading zeros and we shouldn't.

src/index.rs Show resolved Hide resolved
@asmello asmello requested a review from chanced August 5, 2024 22:32
@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.1%. Comparing base (e6c64f8) to head (14d9f17).

Additional details and impacted files
Files Coverage Δ
src/assign.rs 99.6% <100.0%> (+<0.1%) ⬆️
src/index.rs 100.0% <100.0%> (ø)
src/pointer.rs 98.2% <100.0%> (+<0.1%) ⬆️
src/resolve.rs 100.0% <100.0%> (ø)
src/token.rs 100.0% <100.0%> (ø)

@asmello
Copy link
Collaborator Author

asmello commented Aug 5, 2024

@chanced something to look at later: the coverage job is running for each commit, but it should only run in the pull request context. I think some other jobs are also running redundantly.

@chanced
Copy link
Owner

chanced commented Aug 6, 2024

@asmello thanks for the mention, I didn't get a notification for this pull request either. I need to figure out why that is.

@chanced
Copy link
Owner

chanced commented Aug 6, 2024

coverage 🤷

😆
Speaking of which, I really need to go back and clean up the tests at some point.

@chanced chanced merged commit a2453aa into chanced:main Aug 6, 2024
19 checks passed
@chanced
Copy link
Owner

chanced commented Aug 10, 2024

@asmello ugh, I'm sorry. I meant to do a release when I pulled this down but didn't catch that it was aborted. v0.6.0 should be available now.

Screenshot 2024-08-10 at 1 31 35 PM

@asmello
Copy link
Collaborator Author

asmello commented Aug 10, 2024

Ha, no problem, haven't gotten around to using it yet. Thanks for noticing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants