Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update signature of PathBuf::parse #77

Merged
merged 4 commits into from
Oct 18, 2024
Merged

Conversation

asmello
Copy link
Collaborator

@asmello asmello commented Oct 14, 2024

This is what it should've always been. It's technically a breaking change, but I think it's ok because most types that implement AsRef<str> would also implement Into<String>.

@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.0%. Comparing base (9b77908) to head (4a22f15).

Additional details and impacted files
Files with missing lines Coverage Δ
src/pointer.rs 98.1% <100.0%> (+<0.1%) ⬆️

@asmello asmello requested a review from chanced October 14, 2024 23:06
@chanced
Copy link
Owner

chanced commented Oct 16, 2024

Yep, this is definitely what it should have been all along - oops!

Even though it is almost certainly a non-breaking change for the vast majority of codebases, we still need a minor/breaking version bump here, right?

@asmello
Copy link
Collaborator Author

asmello commented Oct 16, 2024

Even though it is almost certainly a non-breaking change for the vast majority of codebases, we still need a minor/breaking version bump here, right?

Yep, that's the responsible thing to do.

@chanced
Copy link
Owner

chanced commented Oct 17, 2024

I just realized the version bump is going to need a minor as well. It sounds like we should just wrap all 3 PRs into one minor release.

@chanced chanced merged commit 6630744 into chanced:main Oct 18, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants