Skip to content

tentative changes to #93 #184

tentative changes to #93

tentative changes to #93 #184

GitHub Actions / clippy failed Nov 18, 2024 in 0s

reviewdog [clippy] report

reported by reviewdog 🐶

Findings (5)

src/diagnostic.rs|175 col 10| error: the following explicit lifetimes could be elided: 's
--> src/diagnostic.rs:175:10
|
175 | impl<'s, T: 'static + ToOwned + ?Sized> IntoOwned for Cow<'s, T> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
note: the lint level is defined here
--> src/lib.rs:38:9
|
38 | #![deny(clippy::all, clippy::pedantic)]
| ^^^^^^^^^^^
= note: #[deny(clippy::needless_lifetimes)] implied by #[deny(clippy::all)]
help: elide the lifetimes
|
175 - impl<'s, T: 'static + ToOwned + ?Sized> IntoOwned for Cow<'s, T> {
175 + impl<T: 'static + ToOwned + ?Sized> IntoOwned for Cow<', T> {
|
src/diagnostic.rs|184 col 1| warning: missing documentation for a trait
--> src/diagnostic.rs:184:1
|
184 | pub trait Diagnose<'s, T> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^
src/diagnostic.rs|185 col 5| warning: missing documentation for an associated type
--> src/diagnostic.rs:185:5
|
185 | type Error: Diagnostic<'s>;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
src/diagnostic.rs|188 col 5| warning: missing documentation for a method
--> src/diagnostic.rs:188:5
|
188 | / fn diagnose(
189 | | self,
190 | | subject: impl Into<<Self::Error as Diagnostic<'s>>::Subject>,
191 | | ) -> Result<T, Report<Self::Error, <Self::Error as Diagnostic<'s>>::Subject>>;
| |
_______________________^
src/diagnostic.rs|194 col 5| warning: missing documentation for a method
--> src/diagnostic.rs:194:5
|
194 | / fn diagnose_with<F, S>(
195 | | self,
196 | | f: F,
197 | | ) -> Result<T, Report<Self::Error, <Self::Error as Diagnostic<'s>>::Subject>>
198 | | where
199 | | F: FnOnce() -> S,
200 | | S: Into<<Self::Error as Diagnostic<'s>>::Subject>;
| |
^

Filtered Findings (0)

Annotations

Check failure on line 175 in src/diagnostic.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] src/diagnostic.rs#L175

error: the following explicit lifetimes could be elided: 's
   --> src/diagnostic.rs:175:10
    |
175 |     impl<'s, T: 'static + ToOwned + ?Sized> IntoOwned for Cow<'s, T> {
    |          ^^                                                   ^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
note: the lint level is defined here
   --> src/lib.rs:38:9
    |
38  | #![deny(clippy::all, clippy::pedantic)]
    |         ^^^^^^^^^^^
    = note: `#[deny(clippy::needless_lifetimes)]` implied by `#[deny(clippy::all)]`
help: elide the lifetimes
    |
175 -     impl<'s, T: 'static + ToOwned + ?Sized> IntoOwned for Cow<'s, T> {
175 +     impl<T: 'static + ToOwned + ?Sized> IntoOwned for Cow<'_, T> {
    |
Raw output
src/diagnostic.rs:175:10:e:error: the following explicit lifetimes could be elided: 's
   --> src/diagnostic.rs:175:10
    |
175 |     impl<'s, T: 'static + ToOwned + ?Sized> IntoOwned for Cow<'s, T> {
    |          ^^                                                   ^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
note: the lint level is defined here
   --> src/lib.rs:38:9
    |
38  | #![deny(clippy::all, clippy::pedantic)]
    |         ^^^^^^^^^^^
    = note: `#[deny(clippy::needless_lifetimes)]` implied by `#[deny(clippy::all)]`
help: elide the lifetimes
    |
175 -     impl<'s, T: 'static + ToOwned + ?Sized> IntoOwned for Cow<'s, T> {
175 +     impl<T: 'static + ToOwned + ?Sized> IntoOwned for Cow<'_, T> {
    |


__END__

Check warning on line 184 in src/diagnostic.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] src/diagnostic.rs#L184

warning: missing documentation for a trait
   --> src/diagnostic.rs:184:1
    |
184 | pub trait Diagnose<'s, T> {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^
Raw output
src/diagnostic.rs:184:1:w:warning: missing documentation for a trait
   --> src/diagnostic.rs:184:1
    |
184 | pub trait Diagnose<'s, T> {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^


__END__

Check warning on line 185 in src/diagnostic.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] src/diagnostic.rs#L185

warning: missing documentation for an associated type
   --> src/diagnostic.rs:185:5
    |
185 |     type Error: Diagnostic<'s>;
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^
Raw output
src/diagnostic.rs:185:5:w:warning: missing documentation for an associated type
   --> src/diagnostic.rs:185:5
    |
185 |     type Error: Diagnostic<'s>;
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^


__END__

Check warning on line 188 in src/diagnostic.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] src/diagnostic.rs#L188

warning: missing documentation for a method
   --> src/diagnostic.rs:188:5
    |
188 | /     fn diagnose(
189 | |         self,
190 | |         subject: impl Into<<Self::Error as Diagnostic<'s>>::Subject>,
191 | |     ) -> Result<T, Report<Self::Error, <Self::Error as Diagnostic<'s>>::Subject>>;
    | |__________________________________________________________________________________^
Raw output
src/diagnostic.rs:188:5:w:warning: missing documentation for a method
   --> src/diagnostic.rs:188:5
    |
188 | /     fn diagnose(
189 | |         self,
190 | |         subject: impl Into<<Self::Error as Diagnostic<'s>>::Subject>,
191 | |     ) -> Result<T, Report<Self::Error, <Self::Error as Diagnostic<'s>>::Subject>>;
    | |__________________________________________________________________________________^


__END__

Check warning on line 194 in src/diagnostic.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] src/diagnostic.rs#L194

warning: missing documentation for a method
   --> src/diagnostic.rs:194:5
    |
194 | /     fn diagnose_with<F, S>(
195 | |         self,
196 | |         f: F,
197 | |     ) -> Result<T, Report<Self::Error, <Self::Error as Diagnostic<'s>>::Subject>>
198 | |     where
199 | |         F: FnOnce() -> S,
200 | |         S: Into<<Self::Error as Diagnostic<'s>>::Subject>;
    | |__________________________________________________________^
Raw output
src/diagnostic.rs:194:5:w:warning: missing documentation for a method
   --> src/diagnostic.rs:194:5
    |
194 | /     fn diagnose_with<F, S>(
195 | |         self,
196 | |         f: F,
197 | |     ) -> Result<T, Report<Self::Error, <Self::Error as Diagnostic<'s>>::Subject>>
198 | |     where
199 | |         F: FnOnce() -> S,
200 | |         S: Into<<Self::Error as Diagnostic<'s>>::Subject>;
    | |__________________________________________________________^


__END__