Skip to content

Commit

Permalink
chore: remove envdir from tox.ini
Browse files Browse the repository at this point in the history
The `envdir` is not supposed to be used that way, and it's broken
"feature" (technically a bug) in tox >= 4. [1]

[1] tox-dev/tox#2788 (comment)
  • Loading branch information
chanchiwai-ray committed May 2, 2024
1 parent 3491e94 commit e6baae5
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 7 deletions.
9 changes: 5 additions & 4 deletions metadata.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ resources:
(Optional) StorCLI deb file published by Broadcom for their RAID devices.
Download v7.26 from: https://docs.broadcom.com/docs/1232743291.
The download will start automatically upon accepting the license agreement.
Unzip the downloaded file and attach the relevant deb package.
Unzip the downloaded file and attach the relevant deb package.
Eg: ./Unified_storcli_all_os/Ubuntu/storcli_007.2612.0000.0000_all.deb
filename: storcli.deb

Expand All @@ -38,7 +38,7 @@ resources:
(Optional) PERCCLI deb file published by Dell for their RAID devices.
Download v7.23 from https://www.dell.com/support/home/en-us/drivers/driversdetails?driverid=tdghn.
Scroll down to "Available Formats" and download the PERCCLI_XXX_Linux.tar.gz file.
Extract the downloaded file and attach the relevant deb package.
Extract the downloaded file and attach the relevant deb package.
Eg: ./PERCCLI_7.2313.0_A14_Linux/perccli_007.2313.0000.0000_all.deb
filename: perccli.deb

Expand All @@ -48,7 +48,7 @@ resources:
(Optional) SASIRCU binary file published by Broadcom.
Download vP20 from https://docs.broadcom.com/docs/12351735.
The download will start automatically upon accepting the license agreement.
Unzip the downloaded file and attach the relevant binary.
Unzip the downloaded file and attach the relevant binary.
Eg: ./SAS2IRCU_P20/sas2ircu_linux_x86_rel/sas2ircu
filename: sas2ircu

Expand All @@ -58,13 +58,14 @@ resources:
(Optional) SASIRCU binary file published by Broadcom.
Download vP16 from https://docs.broadcom.com/docs/SAS3IRCU_P16.zip.
The download will start automatically upon accepting the license agreement.
Unzip the downloaded file and attach the relevant binary.
Unzip the downloaded file and attach the relevant binary.
Eg: ./SAS3IRCU_P16/sas3ircu_rel/sas3ircu_linux_x86_rel/sas3ircu
filename: sas3ircu

provides:
cos-agent:
interface: cos_agent
limit: 1

requires:
general-info:
Expand Down
3 changes: 0 additions & 3 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -27,15 +27,13 @@ passenv =
OS_*

[testenv:dev-environment]
envdir = {toxinidir}/.venv
deps =
pre-commit
{[testenv:lint]deps}
{[testenv:unit]deps}
{[testenv:func]deps}

[testenv:pre-commit]
envdir = {[testenv:dev-environment]envdir}
deps = {[testenv:dev-environment]deps} # ensure that dev-environment is installed
commands = pre-commit run --all-files

Expand All @@ -61,7 +59,6 @@ deps =
{[testenv:func]deps}

[testenv:reformat]
envdir = {toxworkdir}/lint
commands =
black .
isort .
Expand Down

0 comments on commit e6baae5

Please sign in to comment.