Fix term trunc #336
Merged
Fix term trunc #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MHashemzadeh
approved these changes
Apr 19, 2023
kshitijkg
added a commit
that referenced
this pull request
May 17, 2023
dapatil211
added a commit
that referenced
this pull request
May 19, 2023
* Added option to initialize separate components differently * Made minor fixes * Fixed init and registraion * Fix term trunc (#336) (#341) * Fixed issues with moving from done to terminated, truncated * Undo change to logging' scales * Revert changes to this file, SAC agents don't exist yet * Clean up test file Co-authored-by: Darshan Patil <dapatil211@gmail.com> --------- Co-authored-by: Darshan Patil <dapatil211@gmail.com>
dapatil211
added a commit
that referenced
this pull request
Jun 1, 2023
* restore hidden states added * burn in frames feature added * a more general recurrent agent * stateless drqn agent * Remove AtariEnv (#334) * first version. testing. * pylint * pylint * pylint * pylint * pylint * test fix * pylint * pylint * resolve discussion --------- Co-authored-by: artem.zholus <artem.zholus@login-3.server.mila.quebec> Co-authored-by: Darshan Patil <dapatil211@gmail.com> * Update pull_request_ci.yml (#342) * Add initialisation (#340) * Added option to initialize separate components differently * Made minor fixes * Fixed init and registraion * Fix term trunc (#336) (#341) * Fixed issues with moving from done to terminated, truncated * Undo change to logging' scales * Revert changes to this file, SAC agents don't exist yet * Clean up test file Co-authored-by: Darshan Patil <dapatil211@gmail.com> --------- Co-authored-by: Darshan Patil <dapatil211@gmail.com> * new sequence model version * restore hidden states added * burn in frames feature added * a more general recurrent agent * stateless drqn agent * new sequence model version * Update Sequence model to remove coupling with LSTM/GRU * Fix issue with agent_traj_state vs hidden_state * Update config to match new atari env * Fixed issue with storing hidden states in replay buffer --------- Co-authored-by: Artem Zholus <artem.zholus@gmail.com> Co-authored-by: artem.zholus <artem.zholus@login-3.server.mila.quebec> Co-authored-by: Darshan Patil <dapatil211@gmail.com> Co-authored-by: Kshitij Gupta <kshitijkg01@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.