Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SAC agents #337

Merged
merged 7 commits into from
May 17, 2023
Merged

Added SAC agents #337

merged 7 commits into from
May 17, 2023

Conversation

dapatil211
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@hnekoeiq hnekoeiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments. Otherwise, LGTM. Could you also add the link to the results?


class CategoricalPolicyHead(torch.nn.Module):
"""A module that implements a discrete actor head. It uses the ouput from
the :obj:`actor_net`, and adds creates a
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo?

start_method: "fork"
tags:
- benchmark_sac

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove?

action, _, _ = self._actor(observation)
action = action.cpu().detach().numpy()
action = self.unscale_actions(action)
# action = action
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What this comment is for?

Base automatically changed from fix_term_trunc to dev May 3, 2023 16:23
@dapatil211
Copy link
Collaborator Author

Link to results comparing with CleanRL: https://api.wandb.ai/links/dapatil211/1df29fog

@dapatil211 dapatil211 requested a review from hnekoeiq May 3, 2023 16:33
Copy link
Collaborator

@alirahkay alirahkay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hnekoeiq hnekoeiq merged commit 6d11b6a into dev May 17, 2023
@hnekoeiq hnekoeiq deleted the sac branch May 17, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants