-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use throttling-wired octokit everywhere #291
Conversation
🦋 Changeset detectedLatest commit: 3ea6ad4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Ugh, test broke because the mock for |
@@ -26,6 +26,40 @@ import type {} from "@octokit/plugin-throttling/dist-types/types.d"; | |||
// To avoid that, we ensure to cap the message to 60k chars. | |||
const MAX_CHARACTERS_PER_MESSAGE = 60000; | |||
|
|||
const setupOctokit = (githubToken) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, now it makes sense... I totally missed the fact that each command~ has its own octokit instance
@varl let me know if you need help with that |
@Andarist cheers, test fixed in e70152d. If you know of a better way, feel free to change it. Since Hope that works the same way as before since it's the same instance type. |
@varl thank you for your work! I'll release this tomorrow since I just swapped the build system for a new one and I'd prefer not to release it while I'm stepping away from the computer after work 😅 |
Related to #192.
This adds the throttling plugin to other usages of octokit that were overlooked the first time around.
cc: @Andarist