Prefix all server modules with Icepeak.Server #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbert-vdh
requested review from
fatho and
diegodiv
and removed request for
fatho
This allows us to publish the package on Hackage.
robbert-vdh
force-pushed
the
robbert-vdh/server-module-prefix
branch
from
368eeab to
bf42b1e
Compare
diegodiv
approved these changes
May 8, 2023
|
Yeah I normally wouldn't commit random whitespace changes (and @OpsBotPrime merge |
|
Pull request approved for merge by @robbert-vdh, rebasing now. |
|
Rebased as bf42b1e, waiting for CI … |
|
CI job 🟡 started. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed before icepeak can be published to Hackage and used as a library in other applications without causing conflicts.
Resolves #108.