Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metrics on WebSocket queue #99

Merged
merged 4 commits into from
Mar 2, 2023
Merged

Add metrics on WebSocket queue #99

merged 4 commits into from
Mar 2, 2023

Conversation

diegodiv
Copy link
Contributor

@diegodiv diegodiv commented Mar 2, 2023

We wanted to observe how this queue grows and shrinks over time. The metrics are available on the Prometheus endpoint.

fatho
fatho reviewed Mar 2, 2023
View reviewed changes
Copy link
Member

@fatho fatho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically LGTM, but one suggestion:

server/src/Metrics.hs Show resolved Hide resolved
server/src/Core.hs Outdated Show resolved Hide resolved
@diegodiv diegodiv requested a review from fatho March 2, 2023 11:33
fatho
fatho approved these changes Mar 2, 2023
View reviewed changes
Copy link
Member

@fatho fatho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diegodiv diegodiv merged commit 5e7a6e9 into master Mar 2, 2023
@diegodiv diegodiv deleted the dd/add-ws-queue-metrics branch March 2, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fatho fatho fatho approved these changes

@alex-mckenna alex-mckenna Awaiting requested review from alex-mckenna

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diegodiv @fatho