Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support CSS interpolation for Text component #1016

Closed
3 tasks
Dogdriip opened this issue Nov 14, 2022 · 0 comments · Fixed by #1018
Closed
3 tasks

Support CSS interpolation for Text component #1016

Dogdriip opened this issue Nov 14, 2022 · 0 comments · Fixed by #1018
Labels
bug Issues related to anything that isn't working

Comments

@Dogdriip
Copy link
Contributor

Summary

Text component should support CSS interpolation.

Reproduction process

No response

Version of bezier-react

v1.0.0-next-v1.173

Browser

No response

Operating system

  • macOS
  • Windows
  • Linux

Additonal Information

Text 컴포넌트에 interpolation을 받아 적용하는 부분이 빠져 있습니다. 다음과 같이 interpolation을 주입해주어야 합니다.

const Text = styled.span<TextProps & TextStyledProps>`
  // ...
  ${({ interpolation }) => interpolation}
`
@Dogdriip Dogdriip added the bug Issues related to anything that isn't working label Nov 14, 2022
@junbong junbong mentioned this issue Nov 14, 2022
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Issues related to anything that isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(Text): add handling code for unhandled interpolation prop junbong/bezier-react
1 participant
@Dogdriip