-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Text): add handling code for unhandled interpolation prop #1018
fix(Text): add handling code for unhandled interpolation prop #1018
Conversation
🦋 Changeset detectedLatest commit: 083d0a0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 적절한 라벨로 변경했습니다.
- changeset 추가 부탁드립니다!
Codecov ReportBase: 71.15% // Head: 71.16% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## next-v1 #1018 +/- ##
========================================
Coverage 71.15% 71.16%
========================================
Files 208 208
Lines 2961 2962 +1
Branches 821 821
========================================
+ Hits 2107 2108 +1
Misses 736 736
Partials 118 118
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
add changeset for fix
Chromatic Report🚀 Congratulations! Your build was successful! |
Self Checklist
CODEOWNERS
file.Related Issue
Fixes #1016
Summary
Text
component should support CSS interpolation but currently not. So I had add code to handling thisinterpolation
prop.Details
interpolation
prop which is declared inStylableComponentProps
is injectable but not working because there is no handling code currently inText.styled.ts
style file.So I had add some handling code to
Text.styled.ts
style file.I thought that it should be placed after
props.typo
because 'used-place' level injected style is worth than 'code-level' of component.Breaking change or not (Yes/No)
No
References
N/A