Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Rollup 4 #1674

Closed
yangwooseong opened this issue Oct 13, 2023 · 0 comments · Fixed by #1999
Closed

Test Rollup 4 #1674

yangwooseong opened this issue Oct 13, 2023 · 0 comments · Fixed by #1999
Labels
build Issue or PR related to build system

Comments

@yangwooseong
Copy link
Collaborator

Summary

  • Rollup 4 버전에 대해 알아보고 유의미한 빌드 퍼포먼스의 차이를 보인다면 적용합니다.
  • 대응해야 하는 breaking change 가 있는지 확인합니다.

References

@yangwooseong yangwooseong added the build Issue or PR related to build system label Oct 13, 2023
@github-project-automation github-project-automation bot moved this to 📌 Backlog in Bezier React Oct 13, 2023
@sungik-choi sungik-choi mentioned this issue Feb 16, 2024
6 tasks
sungik-choi added a commit that referenced this issue Feb 27, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
<!--
  How to write a good PR title:
- Follow [the Conventional Commits
specification](https://www.conventionalcommits.org/en/v1.0.0/).
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

## Self Checklist

- [x] I wrote a PR title in **English** and added an appropriate
**label** to the PR.
- [x] I wrote the commit message in **English** and to follow [**the
Conventional Commits
specification**](https://www.conventionalcommits.org/en/v1.0.0/).
- [x] I [added the
**changeset**](https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md)
about the changes that needed to be released. (or didn't have to)
- [x] I wrote or updated **documentation** related to the changes. (or
didn't have to)
- [x] I wrote or updated **tests** related to the changes. (or didn't
have to)
- [x] I tested the changes in various browsers. (or didn't have to)
  - Windows: Chrome, Edge, (Optional) Firefox
  - macOS: Chrome, Edge, Safari, (Optional) Firefox

## Summary
<!-- Please brief explanation of the changes made -->

Rollup(#1674), eslint, typescript(채널 lint 설정이 최신화되지 않음)을 제외한 라이브러리들을 최신
버전으로 업데이트합니다.

## Details
<!-- Please elaborate description of the changes -->

- 업데이트 과정에서 발생한 타입 충돌 등을 해결했습니다. 레퍼런스 및 커밋을 참고해주세요.
- browserlist를 업데이트했습니다. 정확한 연유는 모르겠으나, 업그레이드 이후 `postcss-preset-env` 에
의해 cascade layer, `:has` 등의 모던 CSS 기능들이 빌드 과정에서 제거되는 현상이 발생했습니다. 가장 좁은
브라우저 커버리지를 가지는 `:has` 기준으로 브라우저 리스트를 별도 파일로 분리하고, 주석을 추가했습니다.
- `yarn dedupe` 를 실행하여 중복 패키지 버전을 최소화하도록 했습니다.

### Breaking change? (Yes/No)
<!-- If Yes, please describe the impact and migration path for users -->

No

## References
<!-- Please list any other resources or points the reviewer should be
aware of -->

- ~~https://storybook.js.org/blog/optimize-storybook-7-6/ : 스토리북 빌드 시
babel대신 swc를 사용하도록 하는 설정을 추가~~
- testing-library/jest-dom#511 :
testing-library가 @types를 포함하지 않도록 변경되면서, tsconfig에 jest config 파일을 추가
- [브라우저
커버리지](https://browsersl.ist/#q=%3E%3D+1%25+in+KR%2C%0A%3E%3D+1%25+in+JP%2C%0A%3E%3D+1%25+in+US%2C%0Anot+dead%2C%0AChrome+%3E%3D+105%2C%0AEdge+%3E%3D+105%2C%0Anot+Edge+%3C+105%2C%0AFirefox+%3E%3D+121%2C%0AiOS+%3E%3D+15.4%2C%0ASafari+%3E%3D+15.4%2C%0AAndroid+%3E%3D+121%2C%0AOpera+%3E%3D+91%0ASamsung+%3E%3D+20&region=KR).
기존 브라우저 커버리지보다 커버리지가 높습니다.
@sungik-choi sungik-choi mentioned this issue Feb 27, 2024
6 tasks
sungik-choi added a commit that referenced this issue Feb 28, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
<!--
  How to write a good PR title:
- Follow [the Conventional Commits
specification](https://www.conventionalcommits.org/en/v1.0.0/).
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

## Self Checklist

- [x] I wrote a PR title in **English** and added an appropriate
**label** to the PR.
- [x] I wrote the commit message in **English** and to follow [**the
Conventional Commits
specification**](https://www.conventionalcommits.org/en/v1.0.0/).
- [x] I [added the
**changeset**](https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md)
about the changes that needed to be released. (or didn't have to)
- [x] I wrote or updated **documentation** related to the changes. (or
didn't have to)
- [x] I wrote or updated **tests** related to the changes. (or didn't
have to)
- [x] I tested the changes in various browsers. (or didn't have to)
  - Windows: Chrome, Edge, (Optional) Firefox
  - macOS: Chrome, Edge, Safari, (Optional) Firefox

## Related Issue
<!-- Please link to issue if one exists -->

Fixes #1674 

## Summary
<!-- Please brief explanation of the changes made -->

Rollup 버전을 v3에서 v4로 업데이트합니다.

## Details
<!-- Please elaborate description of the changes -->

현재 동작에 영향을 끼치는 변경사항은 없습니다.

### Breaking change? (Yes/No)
<!-- If Yes, please describe the impact and migration path for users -->

No

## References
<!-- Please list any other resources or points the reviewer should be
aware of -->

- https://rollupjs.org/migration/
- https://github.com/rollup/rollup/blob/master/CHANGELOG.md#400
- https://ko.vitejs.dev/guide/migration.html#rollup-4
@github-project-automation github-project-automation bot moved this from 📌 Backlog to ✅ Done in Bezier React Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issue or PR related to build system
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant