Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify config #1748

Closed
sungik-choi opened this issue Nov 21, 2023 · 3 comments · Fixed by #2096
Closed

Unify config #1748

sungik-choi opened this issue Nov 21, 2023 · 3 comments · Fixed by #2096
Assignees
@sungik-choi
Labels
chore:system Issue or PR regarding source environment (e.g. lints, tests), not the actual source code

Comments

@sungik-choi
Copy link
Contributor

Description

eslint, tsconfig 등 설정 파일의 중복을 제거하고 깔끔하게 통일했으면 좋겠습니다.

Reasons for suggestion

현재 eslint config, tsconfig 패키지가 공용 패키지로 분리되어 있으나 담고 있는 설정값이 너무 적어 공통 속성으로서의 역할은 충분히 하지 못하고 있는 상황입니다.

Proposed solution

config/ 디렉토리에 더 다양한 설정값들을 모아놓으면 좋겠음.

  • eslint
  • ts eslint
  • tsconfig (latest 설정 적용)
    • build
    • react
    • node
  • jest
  • pretteir (적용 이후)

References
@sungik-choi sungik-choi added the status:need triage Issue or PR that need triage attention label Nov 21, 2023
@github-project-automation github-project-automation bot moved this to 📌 Backlog in Bezier React Nov 21, 2023
@sungik-choi sungik-choi added chore:system Issue or PR regarding source environment (e.g. lints, tests), not the actual source code and removed status:need triage Issue or PR that need triage attention labels Nov 21, 2023
@sungik-choi
Copy link
Contributor Author

ref: turborepo

@sungik-choi
Copy link
Contributor Author

팀 내부적으로 린트 룰 통일을 진행중입니다.

@sungik-choi
Copy link
Contributor Author

@sungik-choi sungik-choi self-assigned this Mar 18, 2024
@sungik-choi sungik-choi mentioned this issue Mar 21, 2024
Merged
6 tasks
sungik-choi added a commit that referenced this issue Mar 21, 2024
@sungik-choi
Apply shared eslint/typescript config & upgrade to typescript v5 (#2096)
075a0a5 
<!--
  How to write a good PR title:
- Follow [the Conventional Commits
specification](https://www.conventionalcommits.org/en/v1.0.0/).
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

## Self Checklist

- [x] I wrote a PR title in **English** and added an appropriate
**label** to the PR.
- [x] I wrote the commit message in **English** and to follow [**the
Conventional Commits
specification**](https://www.conventionalcommits.org/en/v1.0.0/).
- [x] I [added the
**changeset**](https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md)
about the changes that needed to be released. (or didn't have to)
- [x] I wrote or updated **documentation** related to the changes. (or
didn't have to)
- [x] I wrote or updated **tests** related to the changes. (or didn't
have to)
- [x] I tested the changes in various browsers. (or didn't have to)
  - Windows: Chrome, Edge, (Optional) Firefox
  - macOS: Chrome, Edge, Safari, (Optional) Firefox

## Related Issue
<!-- Please link to issue if one exists -->

- Fixes #1748 
- Fixes #1432 

## Summary
<!-- Please brief explanation of the changes made -->

- https://github.com/channel-io/shared-configs 팀 공용 설정 파일을 바탕으로 configs/
하위에 레포지토리 공용 eslint, typescript config를 설정합니다.
  - supports/ 하위보다 더 명확한 디렉토리명이라고 판단하여 이름 변경
- 전반적으로 중복되는 설정들을 공용 설정으로 이동하고 제거했습니다.

## Details
<!-- Please elaborate description of the changes -->

- eslint의 import/order 규칙을 단순하게 통일하게 되면서 일부 order 변경이 있습니다
- 브라우저용/노드용 패키지를 구분하여 typescript config를 만들었습니다.
- tsconfig의 include 패턴에 와일드카드를 사용하여 단순화했습니다. 와일드 카드를 사용할 필요가 없는 케이스도
마찬가지로 단순화했습니다. (`src/**/*` -> `src`)
- tsconfig의 exclude 패턴에 불필요한 패턴을 정리했습니다 (예: node_modules)
- typescript 버전을 v5.4로 업데이트합니다.
  - `ttypescript` : 패키지가 v5와 호환되지 않아서 ts-patch 라이브러리로 대체합니다
  - cevek/ttypescript#147

### Breaking change? (Yes/No)
<!-- If Yes, please describe the impact and migration path for users -->

No

## References
<!-- Please list any other resources or points the reviewer should be
aware of -->

- https://github.com/channel-io/shared-configs
@github-project-automation github-project-automation bot moved this from 📌 Backlog to ✅ Done in Bezier React Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sungik-choi sungik-choi

Labels
chore:system Issue or PR regarding source environment (e.g. lints, tests), not the actual source code
Projects
No open projects
Bezier React
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Apply shared eslint/typescript config & upgrade to typescript v5 sungik-choi/bezier-react
1 participant
@sungik-choi