Re-implement `Modal` component using `Dialog` in Radix UI#1036

Merged

sungik-choi merged 27 commits intochannel-io:next-v1from sungik-choi:feat/implement-modal

Dec 6, 2022

+2,099-640

Commits on Dec 5, 2022

feat(modal): implement new Modal component
sungik-choi
committed
refactor(modal): rename the previous Modal to LegacyModal
sungik-choi
committed
refactor(modal): rename the new Modal to Modal
sungik-choi
committed
style(modal): fix lint error
sungik-choi
committed
fix(modal): fix compile error (deadcode)
sungik-choi
committed
fix(bezier-react): install missing radix-dialog package
sungik-choi
committed
feat(modal): change container prop default value from getRootElement() to document.body
sungik-choi
committed
feat(modal): change zIndex prop default value from 'auto' to 0 to create new stacking context
sungik-choi
committed
refactor(modal): enhance type declaration and formatting
sungik-choi
committed
chore(changeset): add changeset
sungik-choi
committed
docs(modal): add JSDoc
sungik-choi
committed
test(modal): clean the stories
sungik-choi
committed
feat(button): add rest props to pass other props
sungik-choi
committed
feat(modal): fix typo in prop name and enhance a11y of heading group
sungik-choi
committed
feat(modal): add defaultShow prop to ModalOptions to control uncontrolled modal's initial state
sungik-choi
committed
feat(modal): add 'aria-modal' attr to ModalContent to enhance a11y
sungik-choi
committed
refactor(button): fix typecheck error
sungik-choi
committed
test(modal): add unit test
sungik-choi
committed
chore(deps-dev): add @radix-ui/react-visually-hidden 1.0.1
sungik-choi
committed
feat(modal): add hidden prop and change title prop from optional to required
sungik-choi
committed
test(modal): add unit tests about visually hidden
sungik-choi
committed
refactor(modal): rename root component to visually hidden
sungik-choi
committed
style(modal): formatting
sungik-choi
committed
refactor(modal): remove unnecessary condition check
sungik-choi
committed
feat(modal): enhance style to support when the ModalBody is used as stand-alone
sungik-choi
committed
refactor(modal): rename css variable
sungik-choi
committed

Commits on Dec 6, 2022

fix(modal): change element type of ModalHeader and ModalFooter from HTMLDivElement to HTMLElement
sungik-choi
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Re-implement `Modal` component using `Dialog` in Radix UI#1036

Commits on Dec 5, 2022

feat(modal): implement new Modal component

refactor(modal): rename the previous Modal to LegacyModal

refactor(modal): rename the new Modal to Modal

style(modal): fix lint error

fix(modal): fix compile error (deadcode)

fix(bezier-react): install missing radix-dialog package

feat(modal): change container prop default value from getRootElement() to document.body

feat(modal): change zIndex prop default value from 'auto' to 0 to create new stacking context

refactor(modal): enhance type declaration and formatting

chore(changeset): add changeset

docs(modal): add JSDoc

test(modal): clean the stories

feat(button): add rest props to pass other props

feat(modal): fix typo in prop name and enhance a11y of heading group

feat(modal): add defaultShow prop to ModalOptions to control uncontrolled modal's initial state

feat(modal): add 'aria-modal' attr to ModalContent to enhance a11y

refactor(button): fix typecheck error

test(modal): add unit test

chore(deps-dev): add @radix-ui/react-visually-hidden 1.0.1

feat(modal): add hidden prop and change title prop from optional to required

test(modal): add unit tests about visually hidden

refactor(modal): rename root component to visually hidden

style(modal): formatting

refactor(modal): remove unnecessary condition check

feat(modal): enhance style to support when the ModalBody is used as stand-alone

refactor(modal): rename css variable

Commits on Dec 6, 2022

fix(modal): change element type of ModalHeader and ModalFooter from HTMLDivElement to HTMLElement