-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Improve ProgressBar
Storybook docs to be more readable
#1084
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1084 +/- ##
=======================================
Coverage 72.07% 72.07%
=======================================
Files 223 223
Lines 3051 3051
Branches 840 840
=======================================
Hits 2199 2199
Misses 728 728
Partials 124 124 ☔ View full report in Codecov by Sentry. |
Chromatic Report🚀 Congratulations! Your build was successful! |
UsageWidth.storyName = 'Usage (width)' | ||
UsageWidth.parameters = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UsageWidth.parameters = { | |
UsageWidth.parameters = docsParamters |
다른 스토리도 마찬가지 인데, docs 모드의 파라미터를 상단에 선언해두고 같이 쓰면 좋겠습니다.
나중에 이 작성방식이 가이드로 올라갔을때 모드별 파라미터를 한 군데서 관리하면 전체적으로 통일되고 좋을 것 같습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
템플릿이 확실히 정립되면 공통 모듈에 몰아넣어도 괜찮을 거 같습니다.
}, | ||
} as ComponentMeta<typeof ProgressBar> | ||
|
||
export const Playground: ComponentStory<typeof ProgressBar> = (props) => ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Playground = ProgressBar
도 괜찮지 않을까요?
UsageWidth.storyName = 'Usage (width)' | ||
UsageWidth.parameters = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
템플릿이 확실히 정립되면 공통 모듈에 몰아넣어도 괜찮을 거 같습니다.
|
@Dogdriip 리베이스 부탁드립니당 |
이것도 좀 오래된 PR이라 docs 다시 보고 작업해야 될 것 같은데... 일단 draft로 두겠습니다 🥲 |
ProgressBar
Storybook docs to be more readableProgressBar
Storybook docs to be more readable
Self Checklist
CODEOWNERS
file.Related Issue
None.
Summary
ProgressBar
Storybook 및 MDX 문서가 documentation의 기능에 집중할 수 있도록 개선합니다.Details
Kapture.2022-12-22.at.20.22.22.mp4
argTypes
)를Meta
(ProgressBar.stories.tsx
의 default export)에서Playground
Story의 property로 옮깁니다.Playground
스토리 하나입니다.Playground
이외의 다른 스토리(Overview
,Usage*
,*Variant
등)의viewMode
를 docs로 지정하고, Argument controls를 기본으로 숨깁니다.Meta
->ComponentMeta
Story
->ComponentStory
Breaking change or not (Yes/No)
No.
References