Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Enhance the Text component (#1068)" #1086

Merged
merged 2 commits into from
Dec 27, 2022

Conversation

sungik-choi
Copy link
Contributor

@sungik-choi sungik-choi commented Dec 26, 2022

Self Checklist

  • I wrote a PR title in English.
  • I added an appropriate label to the PR.
  • I wrote a commit message in English.
  • I wrote a commit message according to the Conventional Commits specification.
  • I added the appropriate changeset for the changes.
  • [Component] I wrote a unit test about the implementation.
  • [Component] I wrote a storybook document about the implementation.
  • [Component] I tested the implementation in various browsers.
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox
  • [New Component] I added my username to the correct directory in the CODEOWNERS file.

Related Issue

Summary

This reverts commit 65cdafa.

Details

어플리케이션의 사이드 이펙트 및 Badge 등 컴포넌트에서 케스케이딩이 예상한대로 동작하지 않는 문제가 있어 Revert하고, 추후 개선 예정입니다.

Breaking change or not (Yes/No)

No

References

없음

@changeset-bot
Copy link

changeset-bot bot commented Dec 26, 2022

🦋 Changeset detected

Latest commit: be2ca29

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@channel.io/bezier-react Patch
bezier-figma-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Dec 26, 2022

Codecov Report

Base: 72.06% // Head: 72.16% // Increases project coverage by +0.10% 🎉

Coverage data is based on head (be2ca29) compared to base (3aea494).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           next-v1    #1086      +/-   ##
===========================================
+ Coverage    72.06%   72.16%   +0.10%     
===========================================
  Files          223      223              
  Lines         3053     3064      +11     
  Branches       840      841       +1     
===========================================
+ Hits          2200     2211      +11     
  Misses         729      729              
  Partials       124      124              
Impacted Files Coverage Δ
...components/Forms/FormHelperText/FormHelperText.tsx 100.00% <100.00%> (ø)
...es/bezier-react/src/components/Text/Text.styled.ts 100.00% <100.00%> (ø)
packages/bezier-react/src/components/Text/Text.tsx 100.00% <100.00%> (ø)
packages/bezier-react/src/foundation/Typography.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 26, 2022

Chromatic Report

🚀 Congratulations! Your build was successful!

@sungik-choi sungik-choi merged commit 9a50da6 into channel-io:next-v1 Dec 27, 2022
@sungik-choi sungik-choi deleted the revert/1068 branch December 27, 2022 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant