Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete legacy components #1135

Merged

Conversation

sungik-choi
Copy link
Contributor

@sungik-choi sungik-choi commented Feb 15, 2023

Self Checklist

  • I wrote a PR title in English.
  • I added an appropriate label to the PR.
  • I wrote a commit message in English.
  • I wrote a commit message according to the Conventional Commits specification.
  • I added the appropriate changeset for the changes.
  • [Component] I wrote a unit test about the implementation.
  • [Component] I wrote a storybook document about the implementation.
  • [Component] I tested the implementation in various browsers.
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox
  • [New Component] I added my username to the correct directory in the CODEOWNERS file.

Related Issue

없음

Summary

사용하지 않는 레거시 컴포넌트를 제거합니다.

Details

  • LegacyModal(BaseModal 포함), LegacyTab 컴포넌트 제거
  • 레거시 컴포넌트 폴더 디렉터리 정리 및 LEGACY__Radio 컴포넌트를 LegacyRadio 라는 이름으로 export

Breaking change or not (Yes/No)

No

References

없음

@sungik-choi sungik-choi added the refactoring Issue or PR related to refactoring with no functional changes label Feb 15, 2023
@sungik-choi sungik-choi self-assigned this Feb 15, 2023
@changeset-bot
Copy link

changeset-bot bot commented Feb 15, 2023

🦋 Changeset detected

Latest commit: 52685c0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@channel.io/bezier-react Patch
bezier-figma-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sungik-choi sungik-choi changed the title Delete Legacy components Delete legacy components Feb 15, 2023
@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Base: 82.13% // Head: 83.45% // Increases project coverage by +1.32% 🎉

Coverage data is based on head (52685c0) compared to base (e859372).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           next-v1    #1135      +/-   ##
===========================================
+ Coverage    82.13%   83.45%   +1.32%     
===========================================
  Files          310      284      -26     
  Lines         3851     3561     -290     
  Branches       774      714      -60     
===========================================
- Hits          3163     2972     -191     
+ Misses         612      516      -96     
+ Partials        76       73       -3     
Impacted Files Coverage Δ
...eact/src/components/Legacies/Radio/Radio.styled.ts 94.11% <ø> (ø)
...zier-react/src/components/Legacies/Radio/Radio.tsx 85.00% <ø> (ø)
...ezier-react/src/components/Legacies/Radio/index.ts 0.00% <ø> (ø)
...ckages/bezier-react/src/components/Modals/index.ts 0.00% <ø> (ø)
packages/bezier-react/src/utils/storyUtils.ts 85.71% <0.00%> (-14.29%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

Chromatic Report

🚀 Congratulations! Your build was successful!

@sungik-choi sungik-choi merged commit ee776e6 into channel-io:next-v1 Feb 15, 2023
@sungik-choi sungik-choi deleted the feat/delete-deprecated-comp branch February 15, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Issue or PR related to refactoring with no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants